Update gpu tests with Vb build number#952
Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom Feb 26, 2021
Merged
Conversation
anmaxvl
reviewed
Feb 25, 2021
|
|
||
| if osversion.Get().Build < 19566 { | ||
| t.Skip("Requires build +19566") | ||
| if osversion.Get().Build < 19041 { |
Contributor
There was a problem hiding this comment.
Agreed, slap it in the osversion package
Contributor
There was a problem hiding this comment.
Wait hahaha it already exists https://github.com/microsoft/hcsshim/blob/master/osversion/windowsbuilds.go
Contributor
There was a problem hiding this comment.
Well in that case, use this const 😆
Author
There was a problem hiding this comment.
This is what I get for going too fast haha
dcantah
approved these changes
Feb 25, 2021
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Change to using the Vb build const and LGTM
katiewasnothere
force-pushed
the
vb_gpu_tests
branch
2 times, most recently
from
ccae03a to
b725fe7
Compare
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
vb_gpu_tests
branch
from
b725fe7 to
1f8111f
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kathryn Baldauf [email protected]