Renamed FoldingRangeRequestParam => FoldingRangeParams#550
Merged
dbaeumer merged 1 commit intomicrosoft:gh-pagesfrom Aug 29, 2018
Merged
Renamed FoldingRangeRequestParam => FoldingRangeParams#550dbaeumer merged 1 commit intomicrosoft:gh-pagesfrom
dbaeumer merged 1 commit intomicrosoft:gh-pagesfrom
Conversation
Contributor
Author
|
By the way, the |
Contributor
|
Personally, I would prefer changing it to |
Member
|
+1 for removing |
Signed-off-by: Miro Spönemann <[email protected]>
spoenemann
force-pushed
the
msp_foldingRangeParam
branch
from
f082821 to
533a4b9
Compare
spoenemann
changed the title
Contributor
Author
|
Done. |
Member
|
@aeschli can you please decide on this. We should do this sooner than later |
aeschli
added a commit
to microsoft/vscode-languageserver-node
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all other requests, the single parameter type is named
...Params. For consistency, this pattern should also apply to the new folding range request.