Skip to content

Specify logTrace notification #953

Merged
dbaeumer merged 6 commits intomicrosoft:gh-pagesfrom
giltho:gh-pages
Jun 23, 2020
Merged

Specify logTrace notification #953
dbaeumer merged 6 commits intomicrosoft:gh-pagesfrom
giltho:gh-pages

Conversation

@giltho
Copy link
Contributor

@giltho giltho commented Apr 5, 2020 •
edited
Loading

Hi ! This is a follow-up on #943

This is just a draft since :

  • I'd like to add a sentence about the difference between logTrace and logMessage
  • Reference implementation
  • I do now know if logTrace should be a "general" notification or under the window scope
  • There should probably be a client capability added for retro-compatibility. In the case of ocaml-lsp, I'd like to know, depending on the client, if I continue to send logMessage notifications, or if I can send logTrace notifications instead and they will be supported.

@msftclas
Copy link

msftclas commented Apr 5, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@giltho giltho changed the title First draft for logTrace [WIP] Specify logTrace notification Apr 10, 2020
@giltho giltho mentioned this pull request Apr 10, 2020
Merged
@giltho
Copy link
Contributor Author

giltho commented Apr 15, 2020

Added a paragraph that also specifies setTrace, but it can be easily reverted if this is not desired

@giltho giltho changed the title [WIP] Specify logTrace notification Specify logTrace notification May 12, 2020
@giltho
Copy link
Contributor Author

giltho commented Jun 22, 2020

Hi @dbaeumer, is there anything else you'd like added to this PR ? :)
This would be a great feature to have officially in ocaml-lsp

@giltho giltho mentioned this pull request Jun 22, 2020
Merged
@dbaeumer
Copy link
Member

dbaeumer commented Jun 22, 2020

@giltho sorry for that. Only one thing: we can't change the existing 3.15 spec. The changes you dod should go into the 3-16 version here: https://github.com/microsoft/language-server-protocol/blob/gh-pages/_specifications/specification-3-16.md#L9

@giltho
Copy link
Contributor Author

giltho commented Jun 23, 2020

@dbaeumer Nothing to be sorry about 😄
I've moved the changes to 3.16, so it should be ok now

@dbaeumer dbaeumer merged commit 539cbf8 into microsoft:gh-pages Jun 23, 2020
@dbaeumer dbaeumer added this to the 3.16 milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.16

Development

Successfully merging this pull request may close these issues.

3 participants

@giltho @msftclas @dbaeumer