This repository was archived by the owner on May 6, 2022. It is now read-only.
Fixes builds where environment variable has backslashes#3
Merged
khouzam merged 1 commit intomicrosoft:WinRTfrom Jan 8, 2015
Merged
Fixes builds where environment variable has backslashes#3khouzam merged 1 commit intomicrosoft:WinRTfrom
khouzam merged 1 commit intomicrosoft:WinRTfrom
Conversation
…next line as part of the comment)
khouzam
added a commit
that referenced
this pull request
Jan 8, 2015
Fixes builds where environment variable has backslashes
khouzam
pushed a commit
that referenced
this pull request
Jun 18, 2018
Merge pull request #56 from Project-Nagisa/OpenSSL_1_0_2_WinRT-stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an environment variable such as PATH contains a backslash Visual Studio interprets the next line as part of the comment. When a user attempts to build the .sln he or she will see errors relating to a missing brace "}".
Before fix, the following code is generated in winrtcomponent.cpp and Visual Studio does not recognize the brace in the line
}//end:ms\test.batThe user will see error messages of this type:
By encapsulating the environment variable contents in quotation marks we can prevent Visual Studio from marking the brace in "
}//end:ms\test.bat" as being a comment. Generated code with fix: