Python: Refactoring. Use get_function and get_plugin.#6382
Merged
eavanvalkenburg merged 4 commits intomicrosoft:mainfrom May 24, 2024
Merged
Python: Refactoring. Use get_function and get_plugin.#6382eavanvalkenburg merged 4 commits intomicrosoft:mainfrom
eavanvalkenburg merged 4 commits intomicrosoft:mainfrom
Conversation
markwallace-microsoft
added
the
python
github-actions
bot
changed the title
Contributor
Author
|
@microsoft-github-policy-service agree
…On Thu, May 23, 2024 at 8:43 PM microsoft-github-policy-service[bot] < ***@***.***> wrote:
@stefan521 <https://github.com/stefan521> the command you issued was
incorrect. Please try again.
Examples are:
@microsoft-github-policy-service agree
and
@microsoft-github-policy-service agree company="your company"
—
Reply to this email directly, view it on GitHub
<#6382 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6PSU3N2GYDTN6ZMGDCVZTZDZBELAVCNFSM6AAAAABIGI3BPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXHA4TSMBTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
@microsoft-github-policy-service agree
…On Thu, May 23, 2024 at 8:54 PM microsoft-github-policy-service[bot] < ***@***.***> wrote:
@stefan521 <https://github.com/stefan521> the command you issued was
incorrect. Please try again.
Examples are:
@microsoft-github-policy-service agree
and
@microsoft-github-policy-service agree company="your company"
—
Reply to this email directly, view it on GitHub
<#6382 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6PSU74QPOHQWSZZ654CT3ZDZCQ3AVCNFSM6AAAAABIGI3BPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXHEYTMMRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
moonbox3
approved these changes
May 23, 2024
Collaborator
moonbox3
left a comment
moonbox3
left a comment
There was a problem hiding this comment.
LGTM. My small nit is to use named args to make it more clear when reading:
function = kernel.get_function(plugin_name=<name>, function_name=<name>)
May just be my style preference. :)
Contributor
Author
That's a good shout. I've named them. |
Collaborator
|
@stefan521 please run a |
eavanvalkenburg
approved these changes
May 24, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Refactoring some of the code following [this advice](microsoft#6371 (comment)) from the maintainers. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Look up kernel functions and plugins with the `get_function` and `get_plugin` method. Removed the unused `DEFAULT_CHAT_SYSTEM_PROMPT` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Evan Mattson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Refactoring some of the code following this advice from the maintainers.
Description
Look up kernel functions and plugins with the
get_functionandget_pluginmethod. Removed the unusedDEFAULT_CHAT_SYSTEM_PROMPTContribution Checklist