Skip to content

[Bug] Diff Editors are not in the back/forward history #166805

@jasonwilliams

Description

@jasonwilliams

Does this issue occur when all extensions are disabled?: Yes

Version: 1.74.0-insider (user setup)
Commit: 1b1e2a2
Date: 2022-11-18T05:25:18.342Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22000
Sandboxed: Yes

Description

For some reason diff editors are not added to the history when navigating. When doing some digging in this it seems DiffEditors get disposed of when closing the editor (unlike normal single file editors). You can see the group tries to re-open them but falls into the return when they're already disposed, so nothing happens.

Why is this important? In GitHub when reviewing code you can open a file fully in isolation then click back to the diff. In VSCode this isn’t easy to do.
For more context see: #165765

Steps to Reproduce:

Timeline

  1. Navigate to Timeline (so that you get a diff)
  2. Now navigate to another file
  3. press back
  4. VSCode is unable to get back to the diff editor

Source Control

  1. Make a change then go to source control and click the diff
  2. Close the tab then click back
  3. VSCode is unable to get back to the diff editor

Screencast

Source Control

diffHIstory

Timeline

diffHIstoryTimeline

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions