fix(search): Replace crash empty string pattern#101017
Merged
roblourens merged 1 commit intomicrosoft:masterfrom Jun 25, 2020
Merged
fix(search): Replace crash empty string pattern#101017roblourens merged 1 commit intomicrosoft:masterfrom
roblourens merged 1 commit intomicrosoft:masterfrom
Conversation
Replacing by an empty string pattern could lead to an error when trying to conserve case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing by an empty string pattern could lead to an error when trying to conserve case
Cannot read 'toUpperCase' property of undefinedTo test replace "somethingWithEnding" by searching "Ending" and replacing by "" with automatic case enabled
This PR fixes #80553 (probably)