Skip to content

Fix cut & copy for iPad#101702

Merged
rebornix merged 3 commits intomicrosoft:masterfrom
daybrush:cutcopy#101564
Aug 16, 2020
Merged

Fix cut & copy for iPad#101702
rebornix merged 3 commits intomicrosoft:masterfrom
daybrush:cutcopy#101564

Conversation

@daybrush
Copy link
Contributor

@daybrush daybrush commented Jul 3, 2020

This PR fixes #101564

Why do not place anything in the textarea for the iPad.

Can you tell why? I can help.

@ghost
Copy link

ghost commented Jul 3, 2020

CLA assistant check
All CLA requirements met.

@daybrush
Copy link
Contributor Author

@alexdima

When will it be processed?

@dmitry-urenev
Copy link

guys, please merge it! It works, I tested 🤞 I'm really missing that thing!

@rebornix rebornix added this to the August 2020 milestone Aug 16, 2020
@rebornix
Copy link
Member

I found it's a negative side effect of 5d1c4a9 which fixes the iPad detection. Previously on iPadOS, we thought it was not iPad as the user agent is now macOS so we always put the screen reader content into the textarea (so the textarea is never empty). With the fix, we never put anything into the clipboard and since copy falls back to document.execCommand('copy'), we never copy anything out of the textarea.

Since it works fine on iPadOS with isIPad === false previously, I think this fix is fine for iPad.

@rebornix rebornix merged commit 40a54b0 into microsoft:master Aug 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cut & Copy does not work on iPad OS

4 participants