prune the refactor not applicable reasons if there are too many#103203
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Aug 31, 2020
Merged
prune the refactor not applicable reasons if there are too many#103203mjbvz merged 2 commits intomicrosoft:masterfrom
mjbvz merged 2 commits intomicrosoft:masterfrom
Conversation
Member
Author
mjbvz
reviewed
Jul 28, 2020
| return false; | ||
| } | ||
|
|
||
| private appendInvalidActions(actions: vscode.CodeAction[]): vscode.CodeAction[] { |
Collaborator
There was a problem hiding this comment.
Since this we won't be shipping TS 4.0 for another iteration, I think we should keep this logic as it does not rely on the new TS API
See
for an example server version check
mjbvz
force-pushed
the
pranas/refactorreasonpruning
branch
from
cab32a2 to
3c4d81c
Compare
Collaborator
|
Added back the old logic for versions of TS < 4.0. Let me know if there are any problems with the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript server sends back why a refactor is not applicable and vscode has started consuming it as well. At any given time most refactors are not applicable and there are a decent number of refactors, so the refactor list is long. This PR prunes it to the applicable refactors + the top 5 not applicable refactors (which are grayed out and serve to help discoverability). The refactor not applicable reason was discussed here (for more context): microsoft/TypeScript#35098