Running Extensions: sort slowest ⟶ fastest#103336
Merged
alexdima merged 1 commit intomicrosoft:masterfrom Aug 30, 2020
Merged
Conversation
bmalehorn
changed the title
Before, extensions were sorted by: 1. whether or not they were unresponsive 2. name identifier This made it difficult to answer the question "which extensions are slowing me down"? Now, extensions are sorted by: 1. whether or not they were unresponsive 2. last profile time 3. activation time 4. name identifier In practice this means the first time you open running extensions, it will be sorted by activation time. When you profile extensions, it will be sorted by the profile time.
bmalehorn
force-pushed
the
bm/profile-sort
branch
from
e77f04c to
df4b98f
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the
> Developer: Show Running Extensionspage was sorted by:In Windows Task Manager, Mac System Monitor, and
top, the default shows the worst offenders. But the running extensions view is sorted by name identifier. This makes it difficult to answer the question "what's slowing my system down?"Now, extensions are sorted by:
In practice this means the first time you open running extensions, it will be sorted by activation time:
When you profile extensions, it will be sorted by profile time:
I'm not sure if this is the absolute best way to do this - maybe users should be able to choose what to sort by - but it should make it a lot easier to find slow extensions quickly.