Merged
Conversation
|
|
Contributor
|
Thanks @amagupta-collab ! |
Member
Contributor
|
Yes, thanks @sbatten ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #
Issue Fixed - #78219
While using Emmet command - Wrap individual lines with abbreviation, empty lines were also abbreviated.
Fix
After parsing using emmet helper, we get the parsed tree where every node represents the line. Node contains name (tag which will be used to wrap line) , value (content of line).
Fix is to walk the tree and if value isempty and isnotSelfCLosing tag and doesnt contain any children, assign the name field as empty.
How to test
have a text in editor with empty lines, select all lines, CTRL+SHIFT+P, select emmet:wrap individaul lines with abbr and type p*