Merged
Conversation
Collaborator
|
Fix looks good. It's pretty late for our current release thought so I'm marking this for august |
Author
|
Awesome! So does that mean my PR doesnt get merged until after July 2020 is released? |
Collaborator
|
Thanks! Will be in the first 1.49 insiders build |
Author
|
Awesome thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #104059
checks if "editor.parameterHint.enabled" is true before showing parameter hints if *.suggest.completeFunctionCalls is enabled.
To test this create a javascript or typescript file and try to complete a function with and without "editor.parameterHints.enabled" set to true.