Don't include this function types in completeFunctionCalls#104479
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Aug 18, 2020
Merged
Don't include this function types in completeFunctionCalls#104479mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
What issue does this fix? |
Contributor
Author
|
Typescript allow annotating function f(this: void) {
// make sure `this` is unusable in this standalone function
}Because |
Collaborator
|
Thanks. Can you also create a normal issue to track this problem. This helps us track issues and verify this PR fixed it |
Contributor
Author
|
I had created #104877 to track this issue. Thanks. |
Collaborator
|
Thanks! This will be in the next VS Code insiders build and is scheduled to ship with VS Code 1.49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #104877