issueReporter: Use DOM API instead of string concatenation#104644
Merged
jrieken merged 1 commit intomicrosoft:masterfrom Aug 28, 2020
Merged
issueReporter: Use DOM API instead of string concatenation#104644jrieken merged 1 commit intomicrosoft:masterfrom
jrieken merged 1 commit intomicrosoft:masterfrom
Conversation
jrieken
requested changes
Aug 17, 2020
jrieken
reviewed
Aug 17, 2020
Member
|
@RMacfarlane please review changes in the issue reporter |
annkamsk
changed the title
RMacfarlane
approved these changes
Aug 25, 2020
jrieken
approved these changes
Aug 25, 2020
jrieken
requested changes
Aug 25, 2020
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Please remove src/vs/base/common/htmlElement.ts and only use $
annkamsk
force-pushed
the
dom-api-instead-string-concat
branch
from
bec60e6 to
e9495c1
Compare
jrieken
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #104643 and 12 (out of ~110) issues discovered by tsec.
Changes are based mostly on using general functions
createHTMLElementandcreateHTMLTableElementfromsrc/vs/base/common/htmlElement.tsin places where previously the HTML was constructed by setting an .innerHTML property.