Making TM_SELECTED_TEXT snippet variable working with overtyped text v2#105440
Merged
jrieken merged 7 commits intomicrosoft:masterfrom Aug 28, 2020
n-gist:feature-snippets-overtyping
Merged
Making TM_SELECTED_TEXT snippet variable working with overtyped text v2#105440jrieken merged 7 commits intomicrosoft:masterfrom n-gist:feature-snippets-overtyping
jrieken merged 7 commits intomicrosoft:masterfrom
n-gist:feature-snippets-overtyping
Conversation
… with overtyped text" This reverts commit e6519cb.
…ertyped text (v2)
Contributor
Author
|
suggestController.ts is entry point of changes I did not implemented fixed storage for small overtypes since calling ITextModel.getValueInRange() is producing garbage anyway. So, simply storing. Restricted by 1000000 bytes as was suggested. off topic |
jrieken
requested changes
Aug 27, 2020
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Looking pretty good already. A few nits and something about the widget vs model as resume/pause driver.
…ons, init arrays via []
jrieken
approved these changes
Aug 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #105220
Fixes #62907