Merged
Conversation
reduce the CSS required by 2 lines and (mainly) align it to the perceived center instead of aligning to the top.
change url protocol from http to https fix broken link http://source.icu-project.org/repos/icu/ to point to Github repository instead
while proposed changes are in the works in a separate PR
reduce code required to detect when to set `hasDifferentOriginAncestorFlag` to true
prevent merging a separate PR with this one
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce code required to check whether to set
hasDifferentOriginAncestorFlagtotrue.This PR fixes # None (N/A)
Note: the ThirdPartyNotices.txt file seems to be caching from my previous commit and adding a line. This PR does not address anything in that file.