Fix auto-surround closes with an open character#147187
Merged
alexdima merged 7 commits intomicrosoft:mainfrom Oct 24, 2022
Merged
Fix auto-surround closes with an open character#147187alexdima merged 7 commits intomicrosoft:mainfrom
alexdima merged 7 commits intomicrosoft:mainfrom
Conversation
joyceerhl
approved these changes
Oct 24, 2022
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
Co-authored-by: Alexandru Dima <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163115
This PR fixes an issue that the auto surround function incorrectly closes with an opening character (e.g.
().This issue happens when using an IME, and I confirmed reproduction in Windows and Web. (VSCode version 1.66.1)
The issue seemed to be caused by passing an opening character to the parameter
_charAfterof theCompositionSurroundSelectionCommandconstructor.Before the fix: closes with
(After the fix: closes with
)