Focus editor for tab after dragged over for 1500 millis#149604
Merged
bpasero merged 2 commits intomicrosoft:mainfrom Jun 7, 2022
Merged
Focus editor for tab after dragged over for 1500 millis#149604bpasero merged 2 commits intomicrosoft:mainfrom
bpasero merged 2 commits intomicrosoft:mainfrom
Conversation
Member
|
I pushed a small 💄 and think the code is generally OK to ship like this but I do agree:
Some pointers:
My first thought was to align activity bar and tabs to be 800ms, but then I feel maybe users are getting frustrated that the active editor changes so quickly when you drag and drop over tabs? @mjbvz thoughts on this? Maybe also @daviddossett ? |
Collaborator
|
I think 800 is fine. Comparing the two.. 800ms800ms.mp41500ms1500ms.mp4It might make sense to consider this a setting that applies to these situations globally at some point so users can tune it. Kind of like the macOS example @bpasero mentioned. Rather than having a specific setting for each one, that is. |
bpasero
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #148664
This PR fulfills the requirements, but I think it could be better.
Perhaps we need a setting to indicate if this feature should be active
and also how long the delay should be before we focus the other editor?