Skip to content

Add option to always reveal tests after state change#152331

Merged
connor4312 merged 3 commits intomicrosoft:mainfrom
babakks:reveal-test-on-state-change
Jun 16, 2022
Merged

Add option to always reveal tests after state change#152331
connor4312 merged 3 commits intomicrosoft:mainfrom
babakks:reveal-test-on-state-change

Conversation

@babakks
Copy link
Contributor

@babakks babakks commented Jun 16, 2022

This PR fixes #151847

A new configuration parameter, named testing.alwaysRevealTestOnStateChange, is added. When enabled, after a test's state has changed, the tree view expands to reveal the corresponding item. The default value of the new parameter is set to false, which keeps the existing behavior in place.

@babakks babakks changed the title Add optional to always reveal tests after state change Add option to always reveal tests after state change Jun 16, 2022
@babakks
Copy link
Contributor Author

babakks commented Jun 16, 2022

@connor4312 Could you please review this?

@babakks babakks marked this pull request as ready for review June 16, 2022 13:48
@connor4312
Copy link
Member

Thanks for the PR! Since this option affects followRunningTest, it'd probably make sense to have the description be something like:

Always reveal the executed test when testing.followRunningTest is on. If this setting is turned off, only failed tests will be revealed.

@babakks babakks force-pushed the reveal-test-on-state-change branch from 9f13279 to fc6427e Compare June 16, 2022 20:17
@babakks
Copy link
Contributor Author

babakks commented Jun 16, 2022

@connor4312 Done.

@connor4312 connor4312 merged commit c462359 into microsoft:main Jun 16, 2022
@connor4312 connor4312 added this to the June 2022 milestone Jun 16, 2022
@babakks babakks deleted the reveal-test-on-state-change branch June 16, 2022 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TestExplorer] the testing.followRunningTest no longer auto expand parent test items

3 participants