Fix missing horizontal bracket guides when editor.wrappingIndent == "same"#152529
Merged
hediet merged 1 commit intomicrosoft:mainfrom Jun 23, 2022
Merged
Fix missing horizontal bracket guides when editor.wrappingIndent == "same"#152529hediet merged 1 commit intomicrosoft:mainfrom
hediet merged 1 commit intomicrosoft:mainfrom
Conversation
…same" (microsoft#149074) The if statement removed prevents any guides in case of wrapped line with no wrapping-indentation (i.e. when the starting column of the new line is the first). This prevented the rendering of horizontal guides. Removing the statement also does not lead to wrongfully diplayed vertical lines.
|
|
hediet
approved these changes
Jun 23, 2022
bpasero
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #149074
The if statement removed prevents any guides in case of wrapped line with no wrapping-indentation (i.e. when the starting column of the new line is the first).
This prevented the rendering of horizontal guides.
Removing the statement also does not lead to wrongfully diplayed vertical guides (see example below).