Skip to content

Fixes detaching a terminal editor doesn't fire vscode.window.onDidCloseTerminal event#152791

Merged
Tyriar merged 1 commit intomicrosoft:mainfrom
jeanp413:fix-152785
Jun 21, 2022
Merged

Fixes detaching a terminal editor doesn't fire vscode.window.onDidCloseTerminal event#152791
Tyriar merged 1 commit intomicrosoft:mainfrom
jeanp413:fix-152785

Conversation

@jeanp413
Copy link
Contributor

This PR fixes #152785

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works. This is one of the problems called out in #152302

@Tyriar Tyriar added this to the June 2022 milestone Jun 21, 2022
@Tyriar Tyriar mentioned this pull request Jun 21, 2022
@Tyriar Tyriar merged commit aae33f1 into microsoft:main Jun 21, 2022
@jeanp413 jeanp413 deleted the fix-152785 branch June 21, 2022 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detaching a terminal editor doesn't fire vscode.window.onDidCloseTerminal event

3 participants