Added cursor pointer in monaco select box for consistency#152976
Merged
rzhao271 merged 1 commit intomicrosoft:mainfrom Aug 4, 2022
Merged
Conversation
Collaborator
|
I noticed in the file that there's different rules for |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
I'd follow the same pattern done in the debug viewlet, which is to show a pointer on the dropdown. |
rzhao271
previously approved these changes
Jul 25, 2022
rzhao271
force-pushed
the
feature/152465-show-pointer-in-monaco-select-box
branch
from
52e30f7 to
dbf99ca
Compare
Collaborator
|
I'll merge this in August so that it gets more Insiders testing. |
roblourens
approved these changes
Aug 4, 2022
rebornix
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #152465