@aeschli will this help #138093?

@gjsjohnmurray Yes, it should help in conjunction of an extension like mine (Explicit Folding).

@aeschli Hi, could you tell me if the PR needs any modifications? Thx

+1

@aeschli Hi, what can I do for the PR to be merged? Thx

Sorry, I didn't find time yet to review the PR...

I made a few changes. The problem is that the folding code is in the editor layer which does not have the concept of extensions (it is also used in the Monaco editor). So when using the extension id in the foldingStrategy setting, we have to talk about an abstract id instead of the extension id. But then users will not understand it.
-> I came up with a separate settings editor.defaultFoldingRangeProvider which is defined in the workbench layer

@aeschli Thank you for the update.
I don't quite understand the separation issue between the editor layer and extensions. Since src/vs/editor/contrib/folding/browser/folding.ts was only importing ExtensionIdentifier which is already imported by src/vs/editor/common/languages.ts.
But I'm ok with the changes you made. It solves the current issue.

It's not about the import, which is fine to use, but the description of editor.foldingStrategy: we can't write that the valid settings are indent | auto | extension-id. That sentence would not make sense in Monaco. So there's now a separate setting (editor.defaultFoldingRangeProvider), only available in VS Code, used when auto is the folding strategy.

@daiyam Thanks for your help!

@aeschli Thx

OK, I understand. Since it is a Monaco's property, it should conform to its definition (defined by Monaco).
All the while, I was trying to avoid an additional property...

Thanks for this. It would be even more awesome if one could restrict it to a file name or a partial file name, like *.config.xml. Or is that going to be available in your extension @daiyam?

Use cases are log files which all have their own standards, various config files which also differs a lot. The only way to distinguish them is by their file name.

Its already possible to scope the setting to a specific language

        "[javascript]": {
                "editor.defaultFoldingRangeProvider": "aeschli.ext-foldingrangeprovider"
        }

And if your files represent a certain type of xml files, you could think of defining a language for it. Thats of course something a extension would have to implement and is more than just the language definition.

Alright thanks!

For future reference, here's the issue tracking scoping by filename in the Explicit Folding extension.

zokugun/vscode-explicit-folding#87