Default to config icon for the property language#158454
Merged
aeschli merged 4 commits intomicrosoft:mainfrom Sep 26, 2022
Merged
Default to config icon for the property language#158454aeschli merged 4 commits intomicrosoft:mainfrom
aeschli merged 4 commits intomicrosoft:mainfrom
Conversation
The built-in extension for ini files defines the language for properties files, like .gitconfig and .conf, which are language agnostic properties files that should be represented by a language agnostic icon. The Seti icon theme defines a cogwheel icon for properties files, but additionally associates files with the .properties extension with Java. Coincidentally, the first file extension listed for the properties language is ".properties", which causes the build script for Seti to make the Java icon the default icon for all config files, and just overrides the icon for files like .gitconfig. This should be the other way around, so the Java icon for .properties is the exception for properties, and not the default. Fix: This patch moves the .conf extension to the top of the list of file extensions in the built-in ini-extension and reruns the Seti build script, making the config icon the default. Fixes microsoft#158453.
|
|
aeschli
approved these changes
Sep 26, 2022
dbaeumer
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in extension for ini files defines the language for properties
files, like .gitconfig and .conf, which are language agnostic properties
files that should be represented by a language agnostic icon.
The Seti icon theme defines a cogwheel icon for properties files, but
additionally associates files with the .properties extension with Java.
Coincidentally, the first file extension listed for the properties
language is ".properties", which causes the build script for Seti to
make the Java icon the default icon for all config files, and just
overrides the icon for files like .gitconfig.
This should be the other way around, so the Java icon for .properties is
the exception for properties, and not the default.
Fix:
This patch moves the .conf extension to the top of the list of file
extensions in the built-in ini-extension and reruns the Seti build
script, making the config icon the default.
Fixes #158453.