Allow filter widget some vertical movement (#158549)#158583
Merged
joaomoreno merged 12 commits intomicrosoft:mainfrom Sep 26, 2022
Merged
Allow filter widget some vertical movement (#158549)#158583joaomoreno merged 12 commits intomicrosoft:mainfrom
joaomoreno merged 12 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
/assign @joaomoreno |
joaomoreno
requested changes
Aug 24, 2022
joaomoreno
requested changes
Aug 25, 2022
Member
|
Just tried it. The vertical movement is animated due to the CSS animation. We should disable that during DnD. |
Contributor
Author
|
I've pushed a change which I think does what you mean. It also adds vertical move by keyboard after tabbing to the grab handle. |
Contributor
Author
|
Can this be merged soon, ready for when 1.72 Insiders starts building? |
Member
|
Sorry for the delay @gjsjohnmurray, will try to get to this early next week. |
Member
|
There was one more issue: this broke the closing animation. I've pushed a fix for it. Thanks @gjsjohnmurray and appologies for the delay! |
joaomoreno
previously approved these changes
Sep 26, 2022
connor4312
reviewed
Sep 26, 2022
joaomoreno
approved these changes
Sep 26, 2022
benibenj
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #158549