Add #ifdef and #ifndef as brackets#161192
Closed
RedCMD wants to merge 5 commits intomicrosoft:mainfrom
Closed
Conversation
Cannot add `#else`, `#elif`, `#elifdef` or `#elifndef` as `brackets` as Vscode does not support 'middle'/'inside' `brackets` this however does not cause any issues
Contributor
|
@hediet This is important to get checked in ASAP -- otherwise the C/C++ experience is regressed with VS Code Insiders, i.e. red |
sean-mcmanus
approved these changes
Sep 21, 2022
Member
|
Closing, as we revert the |
Contributor
|
@hediet Okay, that seems fine. What were the problems though? I was only aware of the problem with |
Member
|
@sean-mcmanus you reported the problem here: #159586 (comment) This one is not fixable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160744
extension of #159997 (#159586)
Cannot add
#else,#elif,#elifdefor#elifndefasbracketsas Vscode does not support 'middle'/'inside'
bracketshowever, it does not cause any issues