Display warning banner when workspace lies within appRoot (#138815)#161534
Merged
bpasero merged 3 commits intomicrosoft:mainfrom Sep 23, 2022
Merged
Display warning banner when workspace lies within appRoot (#138815)#161534bpasero merged 3 commits intomicrosoft:mainfrom
bpasero merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
/assign @bpasero |
Contributor
Author
|
I just spotted the INativeEnvironmentService layer breaker. @bpasero maybe you can suggest the right way to resolve this. |
Member
|
Yes I am on it. |
Member
|
Thanks! Moved it into a place where we already show warnings. |
bpasero
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #138815.