Specify window consistently with matchMedia calls in browser.ts#164020
Merged
deepak1556 merged 2 commits intomicrosoft:mainfrom Dec 14, 2022
Merged
Specify window consistently with matchMedia calls in browser.ts#164020deepak1556 merged 2 commits intomicrosoft:mainfrom
deepak1556 merged 2 commits intomicrosoft:mainfrom
Conversation
alexdima
approved these changes
Dec 14, 2022
deepak1556
approved these changes
Dec 14, 2022
Kalmaegi
pushed a commit
to Kalmaegi/vscode
that referenced
this pull request
Dec 15, 2022
…osoft#164020) Co-authored-by: Christof Marti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In browser.ts, calls to
matchMediaare done aswindow.matchMedia(...)in 4 locations and justmatchMedia(...)in one remaining location.This PR updates the fifth location to be consistent with the others.
We are currently patching this in our fork due to an issue with our compiler - but since I think it improves the consistency of the file, it would also be an improvement here too.