Skip to content

Corrected checkboxes on autoLockGroups settings UI (Fixes #164367)#164369

Merged
bpasero merged 4 commits intomicrosoft:mainfrom
r3m0t:auto-lock-editors
Nov 22, 2022
Merged

Corrected checkboxes on autoLockGroups settings UI (Fixes #164367)#164369
bpasero merged 4 commits intomicrosoft:mainfrom
r3m0t:auto-lock-editors

Conversation

@r3m0t
Copy link
Contributor

@r3m0t r3m0t commented Oct 23, 2022

Fixes #164367

Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expand the AUTO_LOCK_REMOVE_EDITORS idea also for the other hardcoded editor: mainThreadWebview-markdown.preview. I think now we also have 2 markdown preview editors in the settings list.

@r3m0t
Copy link
Contributor Author

r3m0t commented Nov 22, 2022

I'm only managing to open the mainThreadWebview version of markdown.preview, how do you open the other version?

Anyway, fixed by removing the checkbox for markdown preview that wasn't working.

@r3m0t r3m0t requested a review from bpasero November 22, 2022 14:01
@bpasero bpasero added this to the November 2022 milestone Nov 22, 2022
@bpasero bpasero enabled auto-merge (squash) November 22, 2022 16:18
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bpasero bpasero merged commit 7165673 into microsoft:main Nov 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't set Interactive window as an auto lock group

4 participants