Skip to content

Add 'Fuzzy Match' toggle to tree find widget (#116286)#164376

Merged
joaomoreno merged 17 commits intomicrosoft:mainfrom
gjsjohnmurray:do-116286
Jan 3, 2023
Merged

Add 'Fuzzy Match' toggle to tree find widget (#116286)#164376
joaomoreno merged 17 commits intomicrosoft:mainfrom
gjsjohnmurray:do-116286

Conversation

@gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Oct 23, 2022

This PR resolves #116286 by adding a 'Match Whole Word' 'Fuzzy Match' toggle button to the tree find widget.

(icon updated after feedback)
junk

This is particularly useful in filter mode.

@gjsjohnmurray
Copy link
Contributor Author

/assign @joaomoreno

@gjsjohnmurray
Copy link
Contributor Author

@lramos15 you might have an opinion about this.

@lramos15
Copy link
Member

@lramos15 you might have an opinion about this.

It's also a bit weird that this doesn't work the way the editor does so we're overloading the behavior of the same icon which can be a bit confusing. I understand this is trying to do contiguous matching vs non-contiguous matching, but in the editor that button actually looks for separate words instead. I'll leave it up to @joaomoreno since this affects the whole tree

@gjsjohnmurray
Copy link
Contributor Author

@lramos15 good point. Looks like I should use the search-fuzzy icon and invert the sense of the toggle.

Perhaps also let users set the default state of the toggle like they already can for the filter/highlight toggle.

@gjsjohnmurray gjsjohnmurray changed the title Add 'Match Whole Word' toggle to tree find widget (#116286) Add 'Fuzzy Match' toggle to tree find widget (#116286) Oct 25, 2022
@gjsjohnmurray
Copy link
Contributor Author

I have changed the icon and added a workbench.list.defaultFindMatchType setting. Also did some renaming in the code.

@gjsjohnmurray
Copy link
Contributor Author

Can this be considered for merging before endgame?

@joaomoreno joaomoreno added this to the January 2023 milestone Jan 2, 2023
@joaomoreno joaomoreno added the tree-widget Tree widget issues label Jan 2, 2023
@joaomoreno
Copy link
Member

This wasn't working if the substring was found at position zero, pushed a fix.

Thanks for the PR, and apologies for the delay @gjsjohnmurray! Happy new year! 🍻

joaomoreno
joaomoreno previously approved these changes Jan 2, 2023
bpasero
bpasero previously approved these changes Jan 3, 2023
@joaomoreno joaomoreno dismissed stale reviews from bpasero and themself via dc12c92 January 3, 2023 10:57
@joaomoreno joaomoreno merged commit 0b11b23 into microsoft:main Jan 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2023
@gjsjohnmurray gjsjohnmurray deleted the do-116286 branch August 16, 2024 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tree-widget Tree widget issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tree: Support continuous find

4 participants