When filtering a tree don't hide unresolved folders (#66971)#164472
When filtering a tree don't hide unresolved folders (#66971)#164472gjsjohnmurray wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
/assign @joaomoreno |
lramos15
added
file-explorer
|
Thanks for creating the PR. We will have to discuss this as from a UX perspective I think it's still a bit weird that you clicked media for example and it just dissappears |
|
@lramos15 yes, a bit weird and I'll be interested to hear feedback from the UX sync. Perhaps some animation would help (fade, then close up the gap). But I think it's less weird than the current experience of no being able to use tree filtering to locate files in folders you haven't expanded at least once. |
|
Nice job! 100% I hope this gets merged. Honestly the |
|
I like the simple approach, and I agree with @ADTC: it's better than today even with the sudden disappearance. I don't think the implementation is correct, though. The situation in which "a node has not yet been resolved" only happens in |
joaomoreno
added
tree-widget
I just submitted #167047 as an attempt to do this. It works, but a critical line of my change produces two TS compile errors. I need guidance about how to resolve these. |
|
Closing in favor of #167047 |
* Another approach to fixing #66971, after feedback on #164472 * add tree.defaultFindVisibility Co-authored-by: João Moreno <[email protected]>
4 participants
This PR addresses #66971. When filtering a tree containing folders whose contents have not yet been fully resolved, retain these folders. This allows the user to expand any whose contents they think might match the filter. If after expanding all nested subfolders there are no matches the folder is excluded from the filtered tree.
Below is an example showing filtering the tree-view-sample Explorer tree for json files without previously having expanded the folders.
Before the change:
After the change:
Observe how the folders remain visible despite their names not matching the filter. Expanding
srcreveals one matching child. Expandingmediaresults in that folder disappearing because it contains no matching children and no subfolders.