adds to files.exclude desc re: explorer.excludeGitIgnore#165111
Merged
lramos15 merged 2 commits intomicrosoft:mainfrom Nov 14, 2022
Merged
adds to files.exclude desc re: explorer.excludeGitIgnore#165111lramos15 merged 2 commits intomicrosoft:mainfrom
files.exclude desc re: explorer.excludeGitIgnore#165111lramos15 merged 2 commits intomicrosoft:mainfrom
Conversation
Adds a note to the description for `files.exclude` to prompt the user to also check the `explorer.excludeGitIgnore` setting.
w3bdesign
previously approved these changes
Nov 1, 2022
lramos15
approved these changes
Nov 14, 2022
hediet
approved these changes
Nov 14, 2022
hughlilly
commented
Nov 14, 2022
| [FILES_EXCLUDE_CONFIG]: { | ||
| 'type': 'object', | ||
| 'markdownDescription': nls.localize('exclude', "Configure [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) for excluding files and folders. For example, the file explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search-specific excludes. See also `#explorer.excludeGitIgnore#`."), | ||
| 'markdownDescription': nls.localize('exclude', "Configure [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) for excluding files and folders. For example, the file explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search-specific excludes. Refer to the `#explorer.excludeGitIgnore#` setting for ignorings files based on your `.gitignore`."), |
Contributor
Author
There was a problem hiding this comment.
Hi @lramos15, thanks for this fix. Unfortunately it introduced a typo: "ignorings files" should have been "ignoring files".
Member
There was a problem hiding this comment.
Haha, silly me. I'll fix this thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a note to the settings label/description for
files.excludeto prompt the user to also check theexplorer.excludeGitIgnoresetting. Prompted by spending ~45 mins trying to remedy the same situation raised in #108206.(I had
explorer.excludeGitIgnoreset totrue, so no matter what changes I made tofiles.excludeandfiles.watcherExclude, the Explorer did not show the node_modules directory Turning off theexcludeGitIgnoreremedied this.)