Skip to content

Fix arrows in side-by-side diff view#165423

Merged
hediet merged 1 commit intomicrosoft:mainfrom
Mingpan:mingpan/fix-diff-revert-arrows
Nov 4, 2022
Merged

Fix arrows in side-by-side diff view#165423
hediet merged 1 commit intomicrosoft:mainfrom
Mingpan:mingpan/fix-diff-revert-arrows

Conversation

@Mingpan
Copy link
Contributor

@Mingpan Mingpan commented Nov 3, 2022

This PR:

  • is a partial fix for Notebook diff revert icon can't be disabled #165189 - the arrows now won't show up in the notebook diff view. This is a fixed behavior, regardless of what the user setting is, following the existing example of other notebook diff configs.
  • addresses the issue that arrows show up even when the right-hand-side editor is readonly (not sure if this is mentioned in an issue before).
  • addresses the issue that sometimes an arrow reverts the wrong deleted block (not mentioned in an issue before as far as I know), please see following gifs for demo:

Before fix:
bug-revert-in-diff

After fix:
fix-revert-in-diff

CC @hediet

I think these are small fixes, but please let me know if I should create additional issues for them, or if anything needs to be fixed / improved in the code. Thanks!

@hediet hediet assigned hediet and unassigned rebornix Nov 4, 2022
@hediet
Copy link
Member

hediet commented Nov 4, 2022

Thanks a lot! :)

@hediet hediet added this to the November 2022 milestone Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants