Use css variables for editor scrollbar#165464
Merged
rzhao271 merged 4 commits intomicrosoft:mainfrom Nov 4, 2022
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
rebornix
approved these changes
Nov 4, 2022
Contributor
Author
|
@rzhao271 Thanks! Can I pick up a few of the other tasks as well then? Or if you could assign me any, that would be great |
Collaborator
|
You can pick up some of the other ones. The |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #165169 task 2
I have replaced the registerThemingParticipant in the file with the appropriate css variables.
I needed to add the rules for the last three since they did not exist in scrollbars.css
Note: This is my first PR ever, and I'm really looking forward to Open Source Development. Let me know if there's anything wrong and I'll fix it asap, and I'll be glad to do a few of the other tasks as well if this one gets merged.