💄 Include file system path in debug mode's URI/link hovers#165709
Merged
roblourens merged 4 commits intomicrosoft:mainfrom Nov 9, 2022
Merged
💄 Include file system path in debug mode's URI/link hovers#165709roblourens merged 4 commits intomicrosoft:mainfrom
roblourens merged 4 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: Babak K. Shandiz <[email protected]>
Member
|
Thanks, good start. But I think the behavior for http URIs should match, and also, I'm wondering whether it should actually include the full value of the variable, not just the link target. For example, you could have |
Signed-off-by: Babak K. Shandiz <[email protected]>
Contributor
Author
|
I've updated the PR. Now it displays the full text: But, it also includes the full text in the links detected inside the debug console. Is that okay? See this:
|
Member
|
Thanks, I like that. But no, this should only be enabled for the debug views |
Signed-off-by: Babak K. Shandiz <[email protected]>
Signed-off-by: Babak K. Shandiz <[email protected]>
Contributor
Author
|
Changed it. Now it only works for the debug view expressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164486
With this PR, only file system URIs (i.e., URIs with
file://scheme or no scheme at all) are also included in the hover box content:Note that the current behavior is kept for other URI schemes (e.g.,
http/https):