Enable opening a local terminal while the remote resolver is running#165742
Merged
Enable opening a local terminal while the remote resolver is running#165742
Conversation
Need to unblock the path to opening a local terminal, triggered by a remote resolver, before the workbench has loaded (ie connected to a remote)
roblourens
changed the title
roblourens
commented
Nov 7, 2022
Member
Author
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Any ideas on how to protect this scenario with a test?
src/vs/workbench/contrib/terminal/browser/terminalInstanceService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/electron-sandbox/terminal.contribution.ts
Show resolved
Hide resolved
Tyriar
requested changes
Nov 7, 2022
src/vs/workbench/contrib/terminal/browser/terminalInstanceService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/electron-sandbox/terminal.contribution.ts
Show resolved
Hide resolved
Member
Do we have resolver tests that assert during startup? Creating a terminal during resolve and asserting it works would cover this case |
Member
Author
|
remote-ssh doesn't have tests that run a live resolver. We run integration/smoke tests with the Test-Resolver, but even if we modify that to create a terminal, it still doesn't cover the case of opening a window that has the right kind of tree open. Maybe there's a useful test that could be written at the unit level, to make sure that some path is not blocked with a LifecycleService in a certain phase? But I don't know how to cover the whole scenario 🤷 |
Tyriar
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix microsoft/vscode-remote-release#7324
Need to unblock the path to opening a local terminal, triggered by a remote resolver, before the workbench has loaded (ie connected to a remote)