Fix snippet overtyping feature#165871
Fix snippet overtyping feature#165871jrieken merged 3 commits intomicrosoft:mainfrom n-gist:broken-snippet-overtyping-fix
Conversation
|
@jrieken, I just moved model cancellation call a line later because, if I'm right, the feature gets the selected text from the model, so it must exist at the time of insertion, but perhaps a better solution is needed |
| }); | ||
|
|
||
| // cancel -> stops all listening and closes widget | ||
| this.model.cancel(); |
There was a problem hiding this comment.
The cancelling must happen before calling insert. It needs a different change which freezes the overtyping capturer before that.
There was a problem hiding this comment.
Reverted.
Changed logic of emptying captured selections and added locking while suggestions widget is active.
This should also fix some non-critical cases when it returned previously saved selection when there were no selection at widget trigger time.
|
Thanks @n-gist |
|
The issue came back after 17.4.2 update. |
1.74.2 working as expected for me |
4 participants
Fix snippet overtyping feature #105440 which stopped working during 1.72 ... 1.73 due to 1e662b0