Skip to content

Restore bracket match CSS syntax (#166109)#166141

Merged
hediet merged 1 commit intomicrosoft:mainfrom
d0ggie:bracketMatchingBorder
Nov 14, 2022
Merged

Restore bracket match CSS syntax (#166109)#166141
hediet merged 1 commit intomicrosoft:mainfrom
d0ggie:bracketMatchingBorder

Conversation

@d0ggie
Copy link
Contributor

@d0ggie d0ggie commented Nov 11, 2022

This restores the CSS border syntax for matching bracket hilighting (#166109).

Prior 83b528d it was border: 1px solid ${bracketMatchBorder}. The current border: var(--vscode-editorBracketMatch-border), as set by the above commit, likely accidentally omits line-width and line-style values that were previously set (1px and solid correspondingly).

As the initial line-style is none the border is not visible (source).

@hediet hediet added this to the November 2022 milestone Nov 14, 2022
@hediet
Copy link
Member

hediet commented Nov 14, 2022

Thanks a lot for the issue and the PR!

@hediet hediet linked an issue Nov 14, 2022 that may be closed by this pull request
@hediet hediet merged commit c9fd476 into microsoft:main Nov 14, 2022
@d0ggie d0ggie deleted the bracketMatchingBorder branch November 14, 2022 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Matching brackets border not functional

3 participants