Skip to content

Adapter css for #165169#167030

Merged
roblourens merged 10 commits intomicrosoft:mainfrom
Kalmaegi:adapter_css_2
Jan 12, 2023
Merged

Adapter css for #165169#167030
roblourens merged 10 commits intomicrosoft:mainfrom
Kalmaegi:adapter_css_2

Conversation

@Kalmaegi
Copy link
Contributor

@Kalmaegi Kalmaegi commented Nov 23, 2022 •
edited by sandy081
Loading

for #165169

  • src/vs/workbench/contrib/debug/browser/callStackEditorContribution.ts

@roblourens roblourens assigned sandy081 and unassigned roblourens Dec 7, 2022
@sandy081
Copy link
Member

sandy081 commented Dec 8, 2022

  • src/vs/workbench/contrib/extensions/browser/extensionEditor.ts
  • src/vs/workbench/contrib/extensions/browser/extensionsActions.ts

Sorry again, I am working on this debt and would like to test and push together. I very much appreciate the effort for doing this. I would request to please revert the changes.

Thanks

@Kalmaegi
Copy link
Contributor Author

Kalmaegi commented Dec 8, 2022

  • src/vs/workbench/contrib/extensions/browser/extensionEditor.ts

  • src/vs/workbench/contrib/extensions/browser/extensionsActions.ts

Sorry again, I am working on this debt and would like to test and push together. I very much appreciate the effort for doing this. I would request to please revert the changes.

Thanks

It's okay, I need to wait until I get up tomorrow morning to submit, see you tomorrow!

@Kalmaegi
Copy link
Contributor Author

Kalmaegi commented Jan 9, 2023

@sandy081 fix it again

@sandy081 sandy081 assigned roblourens and unassigned sandy081 Jan 10, 2023
@roblourens roblourens assigned sandy081 and unassigned roblourens Jan 10, 2023
@sandy081 sandy081 requested a review from roblourens January 12, 2023 10:15
@sandy081
Copy link
Member

sandy081 commented Jan 12, 2023

@roblourens This is adoption in the following file only

  • src/vs/workbench/contrib/debug/browser/callStackEditorContribution.ts

Hence reassigning to you

@roblourens roblourens merged commit e3f31b3 into microsoft:main Jan 12, 2023
@roblourens roblourens added this to the January 2023 milestone Jan 12, 2023
@roblourens
Copy link
Member

roblourens commented Jan 13, 2023

I missed that this is a new css file that isn't even loaded. Did you test this code @weartist?

@roblourens roblourens mentioned this pull request Jan 13, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@roblourens roblourens

@sandy081 sandy081

Labels

None yet

Projects

None yet

Milestone

January 2023

Development

Successfully merging this pull request may close these issues.

4 participants

@Kalmaegi @sandy081 @roblourens @Tyriar