Add new untitled diff command#168533
Conversation
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
This is already very good 👏
I just noticed how we then have these 2 entries:
But the menu calls this differently:
So I have a suggestion:
- we rename
New Untitled FiletoNew Untitled Text File - we rename
New Untitled DifftoCompare New Untitled Text Files
I think we should keep untitled in the label just to support existing users that may have found the command by typing untitled.
I would stay way from using Diff in the name because we mainly refer to the diff editor via compare labels it seems.
|
How about renaming Another benefit is that |
|
No, we cannot. The current wording in the menu was part of an effort to make things more discoverable and understandable if I remember correctly. |
|
To clarify renaming
A few examples of other instances: |
|
Yes, I suggest to change user facing labels, but we cannot change command IDs for backwards compatibility. I think leaving variable names as they are is also fine, but feel free to change them if you feel strong about it. |


Addresses #165123
This PR adds a new command called "New Untitled Diff" that opens a diff editor with two untitled sides.
I added the command in
src/vs/workbench/contrib/files/browser/fileActions.tsbecause the new command is under theFilecategory and similar commands (likeCompare Active File with ...andNew Untitled File) also appear undersrc/vs/workbench/contrib/files/browser/Preview of the feature:
new_untitled_diff.mp4