Fix webview disappearing when extension is slow to start (#168516)#168569
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Dec 15, 2022
Merged
Fix webview disappearing when extension is slow to start (#168516)#168569mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
mjbvz
approved these changes
Dec 15, 2022
Collaborator
|
Thanks! Will be in the next VS Code insiders and should go out to stable with VS Code 1.75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168516
To test:
Build the extension in webview-view-sample folder at https://github.com/r3m0t/vscode-extension-samples/tree/webview-samples-slow and install it into VS Code/Code - OSS Dev
Close Workspace (if any is open)
Choose Foo on the activity bar, it loads eventually:
From Command Palette, run "Add folder to Workspace" and choose a trusted folder.
Correct behaviour: the Foo reloads.
Incorrect behaviour (seen in VS Code Insiders and probably VS Code): see screenshot - the webviews are empty