Add high latency measurement instrumentation to the network protocol#168668
Merged
alexdima merged 13 commits intomicrosoft:mainfrom Dec 21, 2022
Merged
Add high latency measurement instrumentation to the network protocol#168668alexdima merged 13 commits intomicrosoft:mainfrom
alexdima merged 13 commits intomicrosoft:mainfrom
Conversation
…ading msg.id and msg.ack meaning
Tyriar
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #168667
See attached issue for details. But this diff adds support for measuring the latency within the network connection and logs (to logService) measurements of latency that exceed a threshold and also boundary logs of when high latency is detected and resolved. If desired in the future, this could drive a UX feature that shows when a user is in a high latency situation.