Fix for not auto-starting same-named tasks in different folders#168742
Merged
meganrogge merged 5 commits intomicrosoft:mainfrom Dec 13, 2022
Merged
Fix for not auto-starting same-named tasks in different folders#168742meganrogge merged 5 commits intomicrosoft:mainfrom
meganrogge merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
markw65
commented
Dec 10, 2022
meganrogge
requested changes
Dec 13, 2022
Collaborator
meganrogge
left a comment
meganrogge
left a comment
There was a problem hiding this comment.
thanks for looking into this - commented a suggestion
meganrogge
previously approved these changes
Dec 13, 2022
Contributor
Author
|
Just wanted to check what happens next? Will this get merged automatically now, or do I still need to do something? |
meganrogge
approved these changes
Dec 13, 2022
Collaborator
|
@markw65 it will get reviewed by another person before getting merged. nothing left for you to do |
hediet
approved these changes
Dec 13, 2022
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Dec 14, 2022
…osoft#168742) * Fix for not auto-starting same-named tasks in different folders * Use getQualifiedLabel * clean up Co-authored-by: markw65 <[email protected]> Co-authored-by: Megan Rogge <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168741
The recently added
AbstractTaskService._inProgressTasksused the task label to prevent multiple copies of the same task running at the same time. But tasks in different folders can have the same label, and there's no reason not to run them at the same time.There's an example in #168741 that demonstrates the problem without this commit. The example works in 1.73 and earlier, and also works with this pull request.