Fixes editor-area terminals are not restored after quit#168887
Merged
Tyriar merged 2 commits intomicrosoft:mainfrom Dec 16, 2022
Merged
Fixes editor-area terminals are not restored after quit#168887Tyriar merged 2 commits intomicrosoft:mainfrom
Tyriar merged 2 commits intomicrosoft:mainfrom
Conversation
TylerLeonhardt
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168643
Regression from #165742
Problem is the order
onWillShutdownevent gets fired in terminalService, it could fire beforeTerminalEditorInputserialization happens which is also triggered byonWillShutdownevent. so let's move that logic to the TerminalEditorInput itself as it's created much later, also removeshutdownPersistentProcessIdas it was a workaround for this same issue