@Tyriar I found a small problem, here if we use the screen scale as a divisor, it will cause the length and width to be reduced when it is created, on Mac, the scale is 2, probably because we did not consider the screen scale when storing or we don't need to think about it on Mac?

https://github.com/microsoft/vscode/blob/461b3f6184b1668be469901bf0fc75a426e0bb81/src/vs/platform/issue/electron-main/issueMainService.ts#LL284

Cool!

@weartist oh so do we need to also store the scale and only update it when it changes? Going from one monitor to the other for me worked fine so I think something fishy is going on 🤔

It may be related to the operating system, I will look at the related logic, if you do not use scale, will the size of the window on your Windows be enlarged?

Yes, saving the state on my second monitor would make the window 50% larger when I reopen the explorer.

Yes, saving the state on my second monitor would make the window 50% larger when I reopen the explorer.

That probably does need to be scaled, my monitors have the same resolution, I'll check the logic here

I am not sure if it would be worthwhile maybe making this code reusable:

We use it to validate the window state is in bounds of the display. In general I would argue that window state storing and restoring is relatively complex, so there is probably lots of good knowledge already for workbench windows to look at.

Here is how we serialize the state:

I am not sure if it would be worthwhile maybe making this code reusable:

vscode/src/vs/platform/windows/electron-main/windowImpl.ts

Line 1226 in 9e8d780

private validateWindowState(state: IWindowState, displays: Display[]): IWindowState | undefined {

We use it to validate the window state is in bounds of the display. In general I would argue that window state storing and restoring is relatively complex, so there is probably lots of good knowledge already for workbench windows to look at.

Here is how we serialize the state:

vscode/src/vs/platform/windows/electron-main/windowImpl.ts

Line 1112 in 9e8d780

serializeWindowState(): IWindowState {

Thank! I'll go and understand the logic here

@Tyriar Does your monitor have amplified DPI? e.g 200% DPI
strangely, the size we obtained was already scaleFactor, My monitor resolution is 3840 x 2160, I was at the time of getting its size 1920 x 1080 and scaleFactor is 2, when I drag the new window to full screen, The resulting dimensions are almost 1920 x 1080, It doesn't look like you need to consider scaleFactor.
So I was wondering if there were other factors affecting the scaling of the created window, Probably not a location-related issue. Or do your two monitors have different resolutions?

@weartist it's a 4k monitor at 1.5 scale in the OS, next to a 1080p monitor at 1 scale