[typescript] fix potential [object Object] in member completions#171127
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Jan 23, 2023
Merged
[typescript] fix potential [object Object] in member completions#171127mjbvz merged 2 commits intomicrosoft:mainfrom
[object Object] in member completions#171127mjbvz merged 2 commits intomicrosoft:mainfrom
Conversation
mjbvz
approved these changes
Jan 12, 2023
Tyriar
approved these changes
Jan 12, 2023
Contributor
Author
|
I updated base branch to fix ci checks. @Tyriar I think it requires re-approval (though there is no new changes 🤔) |
TylerLeonhardt
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experimenting in TypeScript repo to provide additional information of completion type origin (such as type name there are coming from) in label details. And the insert text of such completions were
[object Object]. I wonder why label handled even in the same branch below but not there...from vscode api perspective it would be much easier to handle such cases, if CompletionItemLabel implemented toString() method that would return the label itself.
I don't really know an easy way to test this, but its easy to test if you remove
tsEntry.labelDetailsif condition above.