Do not block if unable to verify extension signature#172576
Merged
sandy081 merged 2 commits intomicrosoft:mainfrom Jan 27, 2023
dtivel:dtivel/do-not-block
Merged
Do not block if unable to verify extension signature#172576sandy081 merged 2 commits intomicrosoft:mainfrom dtivel:dtivel/do-not-block
sandy081 merged 2 commits intomicrosoft:mainfrom
dtivel:dtivel/do-not-block
Conversation
isidorn
approved these changes
Jan 26, 2023
sandy081
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #168525.
This change makes verification failures (due to inability to perform verification) non-blocking.
CC @isidorn, @sandy081, @joaomoreno
In this case, the following will log in the output window. (The actual reason may be different than
ENOENT.)