fix(keybindings): fix hashcode for scan codes & simple keys#173456
Merged
alexdima merged 2 commits intomicrosoft:mainfrom Feb 5, 2023
Merged
fix(keybindings): fix hashcode for scan codes & simple keys#173456alexdima merged 2 commits intomicrosoft:mainfrom
alexdima merged 2 commits intomicrosoft:mainfrom
Conversation
The issue was introduced in this PR microsoft#169842 The hashcode for scan codes and simple keys was not updated to distinguish between them. fix microsoft#173283 fix microsoft#173325
|
When is it possible to release this hot-fix? |
Contributor
Author
|
@microsoft-github-policy-service agree |
alexdima
approved these changes
Feb 5, 2023
DonJayamanne
approved these changes
Feb 5, 2023
c-claeys
pushed a commit
to c-claeys/vscode
that referenced
this pull request
Feb 16, 2023
…t#173456) * fix(keybindings): fix hashcode scancode/simplekey The issue was introduced in this PR microsoft#169842 The hashcode for scan codes and simple keys was not updated to distinguish between them. fix microsoft#173283 fix microsoft#173325 * Avoid hash collisions between `KeyCodeChord` and `ScanCodeChord` --------- Co-authored-by: Alex Dima <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was introduced in this PR #169842
The hashcode for scan codes and simple keys was not updated to distinguish between them.
fix #173325
fix #173283