Send large RPC messages in chunks#174278
Merged
alexdima merged 3 commits intomicrosoft:mainfrom Feb 22, 2023
Merged
Conversation
Member
|
Let's discuss in #174277 |
…ssages and delay firing the close event until all data has been inflated and emitted (microsoft#174277)
alexdima
approved these changes
Feb 22, 2023
sandy081
approved these changes
Feb 22, 2023
Member
|
Thank you @MarkZuber ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174277
Large RPC message buffers can hold onto the NodeJS thread for a long time, esp on slow networks. This diff sets an upper threshold and anything beyond it will send the message in chunks.