Improve error handling and logging for verification of signed extensions#174730
Merged
sandy081 merged 3 commits intomicrosoft:mainfrom Feb 22, 2023
Merged
Improve error handling and logging for verification of signed extensions#174730sandy081 merged 3 commits intomicrosoft:mainfrom
sandy081 merged 3 commits intomicrosoft:mainfrom
Conversation
Peveylun
previously approved these changes
Feb 18, 2023
Peveylun
left a comment
Peveylun
left a comment
There was a problem hiding this comment.
idk, i just need some commit for my university
isidorn
previously approved these changes
Feb 20, 2023
sandy081
requested changes
Feb 20, 2023
src/vs/platform/extensionManagement/node/extensionSignatureVerificationService.ts
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
February 21, 2023 19:24
Head branch was pushed to by a user without write access
dtivel
force-pushed
the
dtivel/improve-diagnosability
branch
from
a34717a to
c82353d
Compare
sandy081
approved these changes
Feb 21, 2023
isidorn
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #173684, #174332, #174298, and #173250
This change:
The simplest scenario to verify is to enable trace logging and install a signed extension. Then, look in the Shared output window for verbose signature verification output.
CC @isidorn, @joaomoreno, @sandy081